Bump to Rust edition 2021 #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust edition 2018 uses unifies by default dependencies features (see here).
As a consequence, disabling certain features (i.e.
shared-memory) in the mainCargo.tomldoes not end up, as someone could expect, by disabling the actual compilation and linking of such features.A new dependency resolver has been introduced to avoid such problem (see here and it has been the default choice since Rust edition 2021 (see here).
I suggest hence to bump Rust edition to 2021.
Before merging this PR, all Zenoh's sister repos should be provided with a similar PR:
edition = "2021"