Option to skip domain name verification of servers #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fritiofhedstrom
changed the title
Mallets
requested review from
p-avital and
milyin
and removed request for
p-avital
|
Thanks @Fritiofhedstrom for your PR! We need you to sign the Eclipse Contribution Agreement to be able to merge it. In the meanwhile, I've requested @milyin to review the PR. |
Fritiofhedstrom
force-pushed
the
skip_domain_name_verification_of_servers
branch
3 times, most recently
from
f9d07b2 to
d1b4c0f
Compare
p-avital
suggested changes
Aug 7, 2023
| @@ -99,6 +101,12 @@ impl ConfigurationInspector<Config> for TlsConfigurator { | |||
| tls_client_certificate.into(), | |||
| ); | |||
| } | |||
| if let Some(server_name_verification) = c.server_name_verification() { | |||
There was a problem hiding this comment.
you could shorten this to
match c.server_name_verification() {
Some(true) | None => todo!("insert true"),
Some(false) => todo!("insert false"),
}
p-avital
suggested changes
Aug 7, 2023
milyin
reviewed
Aug 7, 2023
Comment on lines
607
to
610
| let server_name_verification: bool = | ||
| if let Some(value) = config.get(TLS_SERVER_NAME_VERIFICATION) { | ||
| value | ||
| } else { | ||
| TLS_SERVER_NAME_VERIFICATION_DEFAULT | ||
| } | ||
| .parse()?; |
There was a problem hiding this comment.
This could be written more shortly:
let server_name_verification: bool = config.get(TLS_SERVER_NAME_VERIFICATION)
.unwrap_or(TLS_SERVER_NAME_VERIFICATION_DEFAULT).parse()?;
Fritiofhedstrom
force-pushed
the
skip_domain_name_verification_of_servers
branch
from
d1b4c0f to
f84d7a6
Compare
|
Please run |
Fritiofhedstrom
force-pushed
the
skip_domain_name_verification_of_servers
branch
from
f84d7a6 to
6701e05
Compare
Fritiofhedstrom
force-pushed
the
skip_domain_name_verification_of_servers
branch
from
6701e05 to
32cd3ec
Compare
Mallets
approved these changes
Aug 8, 2023
p-avital
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#513
Add option "server_name_verification": Option. If set to true (default) servers' certificates must use their IP address or domain name as a common name in their ca-signed certificate in order to connect. If set to false then the servers will be trusted regardless of their common name, this is useful if the IP address of a Zenoh server is difficult to know in advance
Some small fixes on docs for zenoh-cfg-properties that were wrong.