-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
che-4061: change the key format for workspace find method #4115
Conversation
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1949/ |
Signed-off-by: Ann Shumilova <[email protected]>
615204e
to
ba17581
Compare
booting chedir:
connecting with ssh fails:
using ssh with workspace name "local":
while
and with id it's working as well
|
@@ -153,13 +153,6 @@ export class Workspace { | |||
searchWorkspace(key:string):Promise<org.eclipse.che.api.workspace.shared.dto.WorkspaceDto> { | |||
Log.getLogger().debug('search workspace with key', key); | |||
|
|||
// if workspace key is too short it's a workspace name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that by removing that part now we're unable to find a workspace by its name
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1951/ |
Signed-off-by: Ann Shumilova [email protected]
What does this PR do?
The additional changes for this PR #4073
What issues does this PR fix or reference?
#4061
Changelog
Reworked workspace key to new format where namespace can contain / symbols.
Release Notes
Reworked workspace key to new format where namespace can contain / symbols.
Docs PR
Current docs doesn't contain mentions about namespace - nothing to be updated. But the planned docs for teams should contain the namespace description.