CHE-4516: Check command goal name uniqueness ignoring string case considerations on new goal creation #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…siderations on new goal creation
dkulieshov
reviewed
Mar 31, 2017
| final CommandGoal goal = goalRegistry.getGoalForId(goalId); | ||
|
|
||
| goalInitial = goal.getId(); | ||
| goalInitial = editedCommand.getGoal(); |
There was a problem hiding this comment.
Shouldn't it be initialGoal? I'm a bit off the context, but this name seems quite odd to me.
vparfonov
approved these changes
Mar 31, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2345/ |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…siderations on new goal creation (eclipse-che#4656) CHE-4516: Check command goal name uniqueness ignoring string case considerations on new goal creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since Commands Explorer displays all goals names in uppercase we need to check newly created goal name for uniqueness ignoring string case considerations in order to avoid situations like on this screenshot:
So this PR adds checking goal name uniqueness ignoring string case considerations on new goal creation.
Now user will be proposed to enter another goal's name:
What issues does this PR fix or reference?
#4516
Changelog
Now all command goals names must be unique ignoring string case considerations.
Release Notes
N/A
Docs PR
N/A