Add Lua and Databroker support #190

cassava · 2023-12-05T10:12:46Z

Test this with the following:

# Get the code:
git checkout ben/develop

# (Optional) Reset to origin if necessary:
git fetch
git reset --hard origin/ben/develop

# (Optional) Set up separate conan home:
export CONAN_USER_HOME=~/.cache/cloe-0.25.0
mkdir $CONAN_USER_HOME
make setup-conan

# Build cloe:
make export-vendor
echo "0.25.0-develop" > VERSION
make editable
make clean all

# Launch runtime environment:
make setup-python deploy-cli
cloe-launch shell tests/conanfile_all.py
bats tests

tests/test_lua13_bdd_eval.lua

engine/src/lua_setup.cpp

runtime/include/cloe/data_broker.hpp

engine/src/lua_api.hpp

hvolx · 2024-05-23T15:06:56Z

runtime/include/cloe/data_broker.hpp

+  * Detects the presence of the to_lua function (based on ADL)
+  */
+template <typename T>
+constexpr bool has_to_lua_v = has_to_lua<T>::value;


SEVERITY_LOW If I am not wrong, this does not care about the return type of the to_lua function.

hvolx · 2024-05-23T15:10:04Z

runtime/include/cloe/data_broker.hpp

+template <typename T>
+void to_lua(sol::state_view lua) {
+  if constexpr (has_to_lua_v<T>) {
+    to_lua(lua, static_cast<T*>(nullptr));


SEVERITY_LOW What? :D I know you need that parameter T* functionwise but I from a users perspective this does not make sense. People implementing the to_lua function will ask what they are supposed to do with that parameter.

(As per my understanding, the to_lua function is supposed to be implemented as a member function of T)

And having a look at the implementation of the to_lua function in the Wheel class: According to my own trials, the data type of usertype_table["rotation"] is double Wheel::* - I dont understand what exactly is happening tbh. Could you explain this to me once?

hvolx · 2024-05-24T07:36:12Z

runtime/include/cloe/data_broker.hpp

+  if constexpr (has_to_lua_v<T>) {
+    to_lua(lua, static_cast<T*>(nullptr));
+  } else {
+    // nop


How about throwing a proper exception here?

BREAKING CHANGE: If you have implemented any Actions yourself, you will need to make sure the `operator()(const Sync& ...)` returns `cloe::CallbackResult`. You can use `CallbackResult::Ok` to achieve the same behavior.

Linenoise-Source: https://github.com/antirez/linenoise Linenoise-Commit: 93b2db9bd4968f76148dd62cdadf050ed50b84b3 Linenoise-Date: 2023-03-27

- Add slimmed down LRDB library to the engine/vendor/lrdb directory. - It can be compiled in or out via option (in by default) - The command-line flags are --debug-lua and --debug-lua-port

TODO: - Add documentation on how to use it. - Add tests using them. Author: Martin Henselmeyer <[email protected]>

BREAKING CHANGES: - xdg_ functions take and return std::filesystem::path instead of boost::filesystem::path. - Command takes a std::filesystem::path instead of boost::filesystem::path. For the most part, all you need to do is change the namespace to migrate.

cassava · 2024-06-26T13:29:01Z

All Lua stuff in the data broker I would leave as is, since in the next version substantial changes will be introduced from Moritz.

engine/CMakeLists.txt

This provides an easy mechanism to check a simulation configuration for available trigers, signals, etc.

cassava requested a review from tobifalk as a code owner December 5, 2023 10:12

cassava force-pushed the ben/develop branch 3 times, most recently from a8e4de2 to 4e84feb Compare December 8, 2023 11:41

cassava force-pushed the ben/develop branch 3 times, most recently from abcf824 to 1e02a5c Compare March 28, 2024 15:27

cassava force-pushed the ben/develop branch 2 times, most recently from 523cffa to 25c8196 Compare April 22, 2024 11:03

cassava force-pushed the ben/develop branch from 25c8196 to 874a46d Compare May 8, 2024 08:11

cassava changed the title ~~Preparation of commit reorganization for creation of PRs~~ Add Lua and Databroker support May 8, 2024

cassava added this to the 0.25.0 milestone May 8, 2024

cassava self-assigned this May 14, 2024

cassava force-pushed the ben/develop branch 6 times, most recently from e7e0ea4 to d672d71 Compare May 16, 2024 22:09

hvolx reviewed May 21, 2024

View reviewed changes

tests/test_lua13_bdd_eval.lua Show resolved Hide resolved

hvolx reviewed May 23, 2024

View reviewed changes

engine/src/lua_setup.cpp Outdated Show resolved Hide resolved

runtime/include/cloe/data_broker.hpp Show resolved Hide resolved

hvolx reviewed May 23, 2024

View reviewed changes

engine/src/lua_api.hpp Outdated Show resolved Hide resolved

hvolx reviewed May 23, 2024

View reviewed changes

hvolx reviewed May 24, 2024

View reviewed changes

cassava force-pushed the ben/develop branch from d672d71 to df2c734 Compare June 3, 2024 13:08

cassava added 4 commits June 13, 2024 11:30

engine: Remove --distinct option from check command

ab2fc45

engine: Set stack options in own scope

9a7a556

engine: Extract SimulationProgress into simulation_progress.hpp

87d82bc

runtime: Add CallbackResult return value to all action operator()

93b4d24

BREAKING CHANGE: If you have implemented any Actions yourself, you will need to make sure the `operator()(const Sync& ...)` returns `cloe::CallbackResult`. You can use `CallbackResult::Ok` to achieve the same behavior.

cassava and others added 14 commits June 13, 2024 11:30

engine: Restructure code for better compilation times

5ba0e6d

basic: Replace boost::optional with std::optional

2bed94a

engine: Vendor linenoise library

12b60b5

Linenoise-Source: https://github.com/antirez/linenoise Linenoise-Commit: 93b2db9bd4968f76148dd62cdadf050ed50b84b3 Linenoise-Date: 2023-03-27

engine: Add Lua scripting support

f06ce82

engine: Add LRDB debugging support

e014958

- Add slimmed down LRDB library to the engine/vendor/lrdb directory. - It can be compiled in or out via option (in by default) - The command-line flags are --debug-lua and --debug-lua-port

all: Add DataBroker and Signals concepts

a0b8569

TODO: - Add documentation on how to use it. - Add tests using them. Author: Martin Henselmeyer <[email protected]>

engine: Replace boost::optional with std::optional

2769fb2

engine: Replace boost::filesystem with std::filesystem

a155f8b

engine: Add --output-path to cloe-engine

b4a84c7

tests: Add test for cloe-engine --write-output and --output-path

26e43e2

tooling: Add VS Code project configuration

79ec670

tooling: Improve grep-uuids to better show duplicates

4e30255

speedometer: Implement data broker

13ad0fb

cassava force-pushed the ben/develop branch from bb129dd to 13ad0fb Compare June 13, 2024 09:33

cassava added 3 commits June 26, 2024 14:48

all: Improve DataBroker interface for common types

a00f1d5

runtime: Fix duplicate definitions in set_action.hpp

9afe3a4

engine: Fix some findings from clang-tidy

a4c0943

cassava force-pushed the ben/develop branch from 63c7e34 to 2eab6ef Compare June 26, 2024 12:57

hvolx reviewed Jun 27, 2024

View reviewed changes

engine/CMakeLists.txt Show resolved Hide resolved

engine: Add probe subcommand

e206cb0

This provides an easy mechanism to check a simulation configuration for available trigers, signals, etc.

cassava force-pushed the ben/develop branch from 6606fd6 to e206cb0 Compare July 5, 2024 12:34

hvolx approved these changes Jul 5, 2024

View reviewed changes

cassava merged commit 4be46cb into master Jul 5, 2024
10 checks passed

cassava deleted the ben/develop branch July 5, 2024 13:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Lua and Databroker support #190

Add Lua and Databroker support #190

cassava commented Dec 5, 2023 •

edited

Loading

hvolx May 23, 2024 •

edited

Loading

hvolx May 23, 2024 •

edited

Loading

hvolx May 23, 2024

hvolx May 24, 2024

cassava commented Jun 26, 2024

Add Lua and Databroker support #190

Add Lua and Databroker support #190

Conversation

cassava commented Dec 5, 2023 • edited Loading

hvolx May 23, 2024 • edited Loading

Choose a reason for hiding this comment

hvolx May 23, 2024 • edited Loading

Choose a reason for hiding this comment

hvolx May 23, 2024

Choose a reason for hiding this comment

hvolx May 24, 2024

Choose a reason for hiding this comment

cassava commented Jun 26, 2024

cassava commented Dec 5, 2023 •

edited

Loading

hvolx May 23, 2024 •

edited

Loading

hvolx May 23, 2024 •

edited

Loading