Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and refactor system tests #193

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Fix and refactor system tests #193

merged 3 commits into from
Dec 7, 2023

Conversation

cassava
Copy link
Contributor

@cassava cassava commented Dec 5, 2023

Fix:

  • Test configurations depend on any compatible version of cloe-launch-profile
  • Don't fail test when *.so glob does not match anything

Refactor:

  • Nest ' quotes inside " in test definitions instead of nesting " inside ".
    Yes, it works, but it makes working with it more difficult than it needs to be.

@cassava cassava requested a review from tobifalk as a code owner December 5, 2023 13:58
@cassava cassava added this to the 0.21.0 milestone Dec 5, 2023
@cassava cassava self-assigned this Dec 5, 2023
@cassava cassava changed the title Ben/fix minor tests Fix and refactor system tests Dec 5, 2023
@cassava cassava requested a review from clsim December 6, 2023 09:16
@cassava cassava mentioned this pull request Dec 6, 2023
Merged
@cassava cassava added the priority This has a higher priority than otherwise. label Dec 6, 2023
@cassava cassava merged commit 88a92dc into master Dec 7, 2023
3 checks passed
@cassava cassava removed the priority This has a higher priority than otherwise. label Dec 7, 2023
@cassava cassava deleted the ben/fix-minor-tests branch December 7, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clonker clonker clonker approved these changes

@tobifalk tobifalk Awaiting requested review from tobifalk tobifalk is a code owner

@clsim clsim Awaiting requested review from clsim

Assignees

@cassava cassava

Labels
None yet
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cassava @clonker