Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code actions modifying other files don't update current file diagnostics #279

Closed
fbricon opened this issue Jun 27, 2017 · 0 comments · Fixed by #288
Closed

Code actions modifying other files don't update current file diagnostics #279

fbricon opened this issue Jun 27, 2017 · 0 comments · Fixed by #288
Assignees
Labels
Milestone

Comments

@fbricon
Copy link
Contributor

fbricon commented Jun 27, 2017

Following on #262.

Not sure if it's related to the SharedASTProvider, but if you have

public @interface Annot {
}

and

public class Bar {
	@Annot(name="foo")
	public void something{}
}

Quick fix on name, to create the missing name attribute in Annot, will properly add the missing name attribute, but, in vscode, @Annot(name="foo") is still shown as having an error, so hitting the quick fix a second time will add a 2nd name member:

public @interface Annot {
	String name();

	String name();
}

Same issue happens when creating a missing method in another class. If I leave the 1st class that was showing the error and go back, the error doesn't show up, even though the new method was not saved in the 2nd class. Seems like diagnostic reporting is not properly updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants