Skip to content
This repository has been archived by the owner on Jan 15, 2020. It is now read-only.

Migrate to websocket json-rpc implementation from lsp4j #296

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Migrate to websocket json-rpc implementation from lsp4j #296

merged 1 commit into from
Jul 11, 2019

Conversation

tortmayr
Copy link
Collaborator

  • Update to latest lsp4j version to make use of the new websocket json-rpc implementation
  • Migrate standalone implementation from plain websockets to json-rpc over web sockets
  • Remove deprecated server-side implementation for plain websockets

@tortmayr tortmayr requested a review from planger July 10, 2019 14:38
planger
planger approved these changes Jul 11, 2019
View reviewed changes
Copy link
Collaborator

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good to me and works fine!

@planger planger merged commit 13ce781 into master Jul 11, 2019
@tortmayr tortmayr deleted the tortmayr/migrate-websocket branch July 16, 2019 12:39
@tortmayr tortmayr mentioned this pull request Jul 17, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@planger planger planger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tortmayr @planger