This repository has been archived by the owner on Jan 15, 2020. It is now read-only.
Extend GLSP Protocol with "initialize" method #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
martin-fleck-at
commented
Jul 16, 2019
martin-fleck-at
commented
- Allow client to send an initialize with parameters to server
- Extend server to handle initialize and the initialize options
- Add example options that are logged to the Workflow example
- Allow client to send an initialize with parameters to server - Extend server to handle initialize and the initialize options - Add example options that are logged to the Workflow example
tortmayr
reviewed
Jul 17, 2019
| deactivate(): void { | ||
| this.toDeactivate.dispose(); | ||
| } | ||
|
|
||
| protected createInitializeParameters(): InitializeParameters { | ||
| const initOptions = this.createInitializeOptions(); | ||
| return initOptions ? { options: initOptions } : {}; |
There was a problem hiding this comment.
FYI: This could be simplified by reusing the interface key name for the const:
const options = this.createInitializeOptions();
return { options };
tortmayr
approved these changes
Jul 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.