Add correct extension mode to plugin context #35
Conversation
The implementation of the vscode API for the resolution of initial debug configurations as well as the resolution of specific configurations was relying on the registered debug adapter contributors rather than debug configuration providers, this is causing issues e.g. eclipse-theia#9978. This implementation brings access to the debug configuration providers all the way to the browser debug/plugin-debug-service, where the providers can be filtered and then call its corresponding API indirectly. The former API is kept as deprecated. Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
Starting a session from a dynamic debug configuration left it selected as `current` in the `DebugConfigurationManager`, however this selection was not reflected in the debug view as the dynamic configurations are not found under the `launch.json` file. Therefore before this change, starting a debug session clicking the `start` button under the debug view may start a previously run dynamic configuration instead of the one reflected in the GUI. This change fixes the above by leaving the current configuration, and specify the configuration to use in an existing optonal argument.
Co-authored-by: Paul Maréchal <[email protected]>
…#10963) Fixes a bug where the dirty editor warning was shown incorrectly
The commit fixes the styling of the toggled commands in the quick-command menu. Previously, the font-family was incorrect and led to an inconsistent styling with the rest of the commands. Signed-off-by: vince-fugnitto <[email protected]> Co-authored-by: Mark Sujew <[email protected]>
…0965) Fixes a problem with language-overridden editor preference access.
…pse-theia#10941) Fixes a problem preventing resize of some ViewContainerParts.
eneufeld
force-pushed
the
10201-extensionmode
branch
from
0747cd5 to
ad47fcf
Compare
|
Generally looks good to me and works as expected. You probably should add an entry to the |
| @@ -30,6 +30,7 @@ import { | |||
| } from '../common/plugin-api-rpc'; | |||
| import { PluginMetadata, PluginJsonValidationContribution } from '../common/plugin-protocol'; | |||
| import * as theia from '@theia/plugin'; | |||
| import * as types from './types-impl'; | |||
There was a problem hiding this comment.
Why import all and not only ExtensionMode?
There was a problem hiding this comment.
the export is weird, no way to import a single type
I will update the ChangeLOg, the test option is explicitly excluded in the ticket |
Alright, I'm just wondering whether the api should support a type that makes it easier to pass the third value later without needing to change the type from boolean again. But I'm also fine with leaving it as is for now. |
The plugin context was hardcoded to have the production extensionMode. Now a flag is passed to mark a plugin as under development when deploying it. This flag is stored in the plugin metadata and later set in the plugin. When creating the context this flag is then converted to the correct extensionMode. Fix eclipse-theia#10201 Contributed on behalf of STMicroelectronics Signed-off-by: Eugen Neufeld <[email protected]>
eneufeld
force-pushed
the
10201-extensionmode
branch
from
ad47fcf to
d012b64
Compare
The plugin context was hardcoded to have the production extensionMode.
Now a flag is passed to mark a plugin as under development when
deploying it. This flag is stored in the plugin metadata and later set in
the plugin. When creating the context this flag is then converted to the
correct extensionMode.
Fix eclipse-theia#10201
Contributed on behalf of STMicroelectronics
Signed-off-by: Eugen Neufeld [email protected]