Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github HPC actions for ecflow #145

Merged
merged 8 commits into from
Jan 30, 2025
Merged

Add Github HPC actions for ecflow #145

merged 8 commits into from
Jan 30, 2025

Conversation

jjlk
Copy link
Collaborator

@jjlk jjlk commented Jan 16, 2025

This PR aims to add actions related to ecflow server and the HPC.

The idea is to simplify the integration test of the ai-suites repo: https://github.com/ecmwf/ai-suites and to reuse some components in other workflows related to suite execution on HPC in different GIthub repo.

The PR contains three actions to run, monitor (track) and remove the suite.

We (with https://github.com/corentincarton) thought that the actions could be stored in dedicated repositories:

hpc/
└── ecflow
    ├── monitor-suite
    │   └── action.yml
    ├── remove-suite
    │   └── action.yml
    └── run-suite
        └── action.yml

@FussyDuck
Copy link

FussyDuck commented Jan 16, 2025

CLA assistant check
All committers have signed the CLA.

@jjlk jjlk changed the title WIP: Add Github HPC actions for ecflow Add Github HPC actions for ecflow Jan 16, 2025
@jjlk
Copy link
Collaborator Author

jjlk commented Jan 16, 2025

The actions have been tested in the integration test of ai-suites: https://github.com/ecmwf/ai-suites/actions/runs/12814765320, in a dedicated PR: https://github.com/ecmwf/ai-suites/pull/16.

Everything is working as expected.

Do we need to add some tests in the workflows repository?

@jjlk jjlk self-assigned this Jan 16, 2025
@corentincarton
Copy link

Thanks @jjlk, it looks good! @iainrussell, we thought organising the actions using sub-folders would scale better if we add more actions in the future, but feel free to suggest another structure.

@iainrussell
Copy link
Contributor

Hi @corentincarton and @jjlk, I like the idea of the subdirectories for this - not quite sure if hpc/ecflow or ecflow/hpc is better. Generally I prefer the latter, but if we might have a bunch of actions that will only ever run on the hpc, then your version is more suitable, so we should probably stick with that (and I think we can say that ecflow tasks will only ever run on hpcs). Can I merge it in now?

@jjlk
Copy link
Collaborator Author

jjlk commented Jan 21, 2025

HI @iainrussell , thanks for the comments for me it's ok!

@jjlk
Copy link
Collaborator Author

jjlk commented Jan 23, 2025

Here is the result of the last changes on a workflow that uses those actions: https://github.com/ecmwf/ai-suites/actions/runs/12923928972 (everything is green!).

@iainrussell iainrussell merged commit a9b3896 into main Jan 30, 2025
11 checks passed
@iainrussell iainrussell deleted the add_hpc_ecflow_actions branch January 30, 2025 16:15
@iainrussell
Copy link
Contributor

Merged, and tagged with 'v2'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants