Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the HDF5-related functions request more rights than necessary in sections that only read the state. This PR adjusts the rights in the corresponding
H5Fopen
function calls.While it is not fundamentally wrong to request RDWR access here, HDF5 applies a file lock in this case, which can lead to errors if multiple of the cloudsc prototypes are run simultaneously, for example in a benchmark setting. The lock-induced errors look like this:
Note that file locking can also be disabled altogether by setting the environment variable
HDF5_USE_FILE_LOCKING=FALSE
, but users might not be aware of this option.The changes were tested locally, without any trouble.