Add semantic for reading thread count from $OMP_NUM_THREADS #73
Conversation
Zero or negative values given as first argument of the various prototypes led to errors. This commit adds semantic to 0 or negative values by enabling the program to read the OMP_NUM_THREAD value from the environment, or using the number of procs availables if the variable is not defined.
Add first argument values and the associated effect on the multithreaded behavior
|
|
There was a problem hiding this comment.
Hi @antoine-morvan many thanks for the contribution.
I also agree that this is a good idea, but that we might also need the #ifdef guards. However, I've run this and recreated the previous failure, and it all works nicely and as expected, so should be good to go once this is in place.
Regarding the For the in Fortran files that would match what's in the |
|
Should be better with OpenMP-less support :) |
Hello,
I am using some scripts to automatically launch the CloudSC dwarf with various numbers of OpenMP thread. The framework however relies on
$OMP_NUM_THREADto set this value, and cannot act on the executable arguments.This PR does 2 things:
$OMP_NUM_THREADSvariable from the environment if present or defaults to CPU count (omp_get_max_threads());The updated readme should reflect these changes.
This should not break existing behavior, as zero or negative arguments were leading to aplication crash.
Best regards.