Loki: Add yoecldp.F90 header that contains NCLV to fix SCC demotion #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Loki doesn't recognise NCLV as a parameter it will not demote the solver matrix arrays correctly.
|
Closing now, as superseded by #80. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Loki doesn't recognise NCLV as a parameter it will not demote the solver matrix arrays correctly.
@reuterbal This might be related to the last minute Scheduler changes, or might have been broken for a little while (not sure). However, with this in place, we get and the other Loki change we get equivalent performance between the respective "loki" and "gpu" variants again.