Stricter match condition for _fail strings #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdeconinck
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Thanks @cresswellp for this bug fix! Sorry it escaped my attention!
wdeconinck
added a commit
that referenced
this pull request
Nov 18, 2024
* gh/release/3.9.0: Version 3.9.0 Add downstream ci (#72) Fix ecbuild_disable_unused_feature Add workflow to check release version is correct (#54) Add ecbuild_override_compiler_flags macro Add utility to initialise overrideable compiler flags Add utility to purge compiler flags for a given language Add tests according to Github issue #65 Enable distinction between enabled/disabled features Update ci action to v2 (#68) Stricter match condition for _fail strings (#64) CPP out LOC calls for NAG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ecbuild_check_fortrantriggers a string match for"_fail"against a filename held in ecbuild, which can cause an unintended match if the path to the ecbuild installation contains this string. This is easily done in an IFS build if the branch name contains this string, because the cloned ecbuild will sit inside a directory named after the IFS branch, e.g..../user_cycle_fix_failures/source/ecbuild/...The result is that any Fortran feature being checked for is accidentally removed from the list of features to check, resulting in an empty feature list and an instant build failure:
CRITICAL - [Fortran] Expected to find only one feature. Found 0 --Making the match condition stricter against the files it's actually looking for solves the problem.