Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect node splits #181

Closed
FatimaPillosu opened this issue May 19, 2021 · 1 comment
Closed

Incorrect node splits #181

FatimaPillosu opened this issue May 19, 2021 · 1 comment
Assignees
@onyb
Labels
bug Something isn't working priority 1 STOP. This is preventing EVERYONE from using the software.
Milestone
Fix bugs in compu...

Comments

@FatimaPillosu
Copy link
Contributor

At the moment the split has some bug because if I want to split the node highlighted in blue, the split will be applied to the node highlighted in red. Whatever node I select, the split will be always applied to the node in red.
The split is located in the wrong place whether we use the function split of the K-S test.
Any ideas on what could have gone wrong?

Screenshot_2021-05-19_05-45-25
@FatimaPillosu FatimaPillosu added bug Something isn't working priority 1 STOP. This is preventing EVERYONE from using the software. labels May 19, 2021
onyb added a commit that referenced this issue May 20, 2021
@onyb
GH-181: fix incorrect node splits
fde8b53
@onyb
Copy link
Contributor

onyb commented May 21, 2021

Fixed in v0.28.1.

@onyb onyb closed this as completed May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
bug Something isn't working priority 1 STOP. This is preventing EVERYONE from using the software.
Projects
None yet
Milestone
Fix bugs in computations and outputs
Development

No branches or pull requests
2 participants
@onyb @FatimaPillosu