Fix restart statistics tests failing on second run or individual runs #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tweska
force-pushed
the
bugfix/tests-dependencies
branch
from
fbc2d68 to
f129b45
Compare
|
Thanks, Kevin. Do I understand correctly that even with the workarounds this requires the ecbuild change (for the case when there is just a single dependency)? |
|
@dsarmany, yes, although there is a workaround (which looks similar) for that too. After a short discussion we will use the workaround instead to not rely on the ecbuild change. |
tweska
force-pushed
the
bugfix/tests-dependencies
branch
from
f129b45 to
a98ccf7
Compare
tweska
force-pushed
the
bugfix/tests-dependencies
branch
from
a98ccf7 to
eabd87b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handling dependencies in the restart statistics tests.
Draft because this requires a fix in ecbuild: ecmwf/ecbuild#76Can be improved if we figure out how to handle situation when we have a test which has two dependencies. Fixed with workaround for now.