Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse rgb but gives rgba value #929

Merged
merged 2 commits into from
Jun 19, 2022
Merged

Conversation

zhulin3141
Copy link
Contributor

解析rgb颜色时能兼容处理 rgb(2,163,254,1)格式

pissang
pissang previously approved these changes Jun 17, 2022
@pissang
Copy link
Contributor

pissang commented Jun 17, 2022

LGTM. @plainheart Any other thoughts that I may be missing?

@plainheart plainheart self-requested a review June 17, 2022 10:02
Copy link
Collaborator

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Tweaked the code style and added a case for this compatibility strategy to the unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants