Reproduce PR #1479 #1524
Open
Reproduce PR #1479 #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alan rejiggered the contents of distribution.py, so I have recreated the changes from my prior PR into this one. Committing and then will run tests.
|
Two tests fail, and both of them are ones whose values had changed slightly (around 1e-4 or so) in the prior PR. The values the tests are getting are the old values, which indicates that I might have missed a change somewhere. Ugh. |
3 tasks
|
I was indeed missing exactly one line. This PR is now ready for review (and merge, probably). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alan rejiggered the contents of distribution.py, so I have recreated the changes from PR #1479 into this one. Committing and then will run tests.
Please ensure your pull request adheres to the following guidelines: