Use pathlib for file path management #16
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
pathlib
for file path management, which should make cross-platform support easier.This PR resolves #15
pathlib
could be implemented to replace a lot ofos
usage elsewhere in the project, but this PR was focused oncoverage.py
.ATTN: @econchick
The original tests don't run properly on Windows, but this was tested and run on Linux, where all tests passed.
The default
common_base = ""
is nowcommon_base = Path("/")
. I'm not sure if this is fine with you, or if this breaks something in your use case.Tests were updated, but hopefully they still test the properties you intended.
Let me know if there is anything that is not quite right, or some lines that could use some explanation. There are still some cases where a
Path
was converted into astr
or whereos
was used. There may be a more elegant solution that I'm not familiar with.