Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py39 support and drop py35 support #58

Merged
merged 3 commits into from
Oct 13, 2020

Conversation

s-weigand
Copy link
Contributor

Description

Out with the old, in with the new. 😄

Motivation and Context

Python 3.9 was released on 2020-10-05 and Python 3.5 reached its end of life

This PR will conflict with #57 , due to changes in tox.ini

Python 3.9 was released 2020-10-05 https://www.python.org/dev/peps/pep-0596/#id4
and Python 3.5 reached its end of life https://www.python.org/dev/peps/pep-0478/#id4
Thus it would be reasonable to drop py35 support and add py39 support.
Copy link
Owner

@econchick econchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! You're more on top of it than I am ;) just some questions before we proceed any further.

tox.ini Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@s-weigand s-weigand marked this pull request as draft October 6, 2020 22:48
 so PyPi will know of the py35 drop
@s-weigand s-weigand marked this pull request as ready for review October 7, 2020 13:55
@econchick econchick merged commit fcbc1ff into econchick:master Oct 13, 2020
@s-weigand s-weigand deleted the add-py39-support branch October 13, 2020 20:35
@econchick
Copy link
Owner

FYI this has been released (finally) in 1.3.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants