Increase compatibility with Rollbar API #1
Merged
+202
−134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, I removed
code
field as per RoxasShadow#13. Based on the Rollbar engineer's comment, since we don't have access to the source code, we should be omitting this value.However, I was still having grouping issues. In reading through the errors and looking at the settings in Rollbar, i determined that the
exception.class
field being set to the Thread's name is what was causing the grouping errors.Unfortunately, typename is deprecated because a new feature was added to rust 1.38 giving an official way to get the name of a type. I added the usage of this new feature, but that means that if this is merged, there's a new requirement on Rust 1.38 and it appears there's not a way to currently specify that in the Cargo.toml.
I'll be creating an MR back to the main branch with these changes, but I'll also publish a tag if someone wants to use a git ref to refer to my repo.