Fix commander not parsing arguments #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commander does not accept getting the options directly from program. Need to create options variable. Added this line (after .parse(process.argv) ): const options = program.opts(); And replace program by options thereafter.
Fix commander not parsing arguments
Commander does not accept getting the options directly from program. Need to create options variable. Added this line (after .parse(process.argv) ): const options = program.opts(); And replace program by options thereafter.
edasque
reviewed
Mar 29, 2021
dynamoDBtoCSV.js
Outdated
| console.log("You must specify a table"); | ||
| program.outputHelp(); | ||
| options.outputHelp(); |
There was a problem hiding this comment.
I don't think that's correct. options is doesn't have an outputHelp method. it's a program.OptionValue
|
good point. Any other?
…On Mon, 29 Mar 2021 at 15:25, Erik Dasque ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In dynamoDBtoCSV.js
<#66 (comment)>:
> console.log("You must specify a table");
- program.outputHelp();
+ options.outputHelp();
I don't think that's correct. options is doesn't have an outputHelp
method. it's a program.OptionValue
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#66 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADCUFVK4PKJD2WOYN2VHK3LTGDH4LANCNFSM42AE5TDA>
.
|
Add ProjectionExpression: options.select to the ScanQuery to fix --select not selecting specific fields if no primary key is presented.
rafaelribeirokuhn
approved these changes
Apr 8, 2021
|
It took some time for me to figure out what was going on and to fix this error. I was going to open a PR exactly like this one when I saw it already has been made. I wish this PR has been merged before :( |
|
This should be merged into the main branch. I had the same issue and using the code in this branch worked |
DollarAkshay
approved these changes
Apr 10, 2021
|
Why has this not been merged yet? This project is not functional without this. UPDATE: This seems now out of date. Merging it locally fails with this error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commander does not accept getting the options directly from program.
Need to create options variable.
Added this line (after .parse(process.argv) ):
const options = program.opts();
And replace program by options thereafter.