Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial error pages for network #464

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AliTopal89
Copy link

so I mixed this approach with this because I don't know if it is necessary to create views for error pages if that is the case and you would like me to approach it that way then I can further work on these errors but for the meantime both errors that I created gave me the logs

Processing by ErrorsController#not_found as HTML
  Parameters: {"id"=>"123"}
  Rendered public/404.html within layouts/application (1.1ms)
Completed 404 Not Found in 316ms (Views: 316.0ms | ActiveRecord: 0.0ms)

and

Processing by ErrorsController#internal_server_error as HTML
  Rendered public/500.html within layouts/application (0.1ms)
Completed 500 Internal Server Error in 143ms (Views: 142.1ms | ActiveRecord: 0.0ms)

here are the snapshots as well with really basic css, which I modified from the existing public folder
screen shot 2017-03-04 at 3 38 17 pm

and

screen shot 2017-03-04 at 3 39 44 pm

Please let me know if you have any questions or concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants