Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in validate benchmark? #89

Closed
anthonynorth opened this issue Jan 18, 2024 · 2 comments
Closed

Bug in validate benchmark? #89

anthonynorth opened this issue Jan 18, 2024 · 2 comments

Comments

@anthonynorth
Copy link

There looks to be a bug in the validate json benchmark. {yyjsonr} is reading a file into memory instead of validating it.

rcppsimdjson/demo/simpleBenchmark.R

Line 19 in 7100cac

yyjsonr = yyjsonr::read_json_file(file),

I think this should be:

yyjsonr = yyjsonr::validate_json_file(file),
@eddelbuettel
Copy link
Owner

My bad, I will fix that.

@eddelbuettel
Copy link
Owner

Now done, thanks for catching that.

eddelbuettel added a commit that referenced this issue Jan 18, 2024
@eddelbuettel
Correct first benchmark which is validation-only (closes #89)
9187719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anthonynorth @eddelbuettel