Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configs + Code cleanup #13

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

charlesyz
Copy link

Hello! Great work on the project.

I wanted to clean up the code a bit so I and others can build upon this repo for future tracking efforts

  • Use YAML config files
  • Use Dependency injection to select which algorithms and covariances to use (see algorithms.py and covariance.py)
  • Isolate IOU/distance metric calculation and matching algorithms into separate functions in algorithms.py
  • Move util functions to utils/geometry_utils.py and generic_utils.py

I tested the code with configurations in the readme (config/AB3DMOT.yaml and config/mahalanobis.yaml) and was able to reproduce the results cited in the README.

@eddyhkchiu
Copy link
Owner

Thank you very much for the update suggestions! I will keep this pull request open since we have more than one pull request which may conflict with each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants