Feature/rmk 29 refactor internal logic of rmk cluster provider initialization and selection #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
anovikov-el
requested changes
Oct 2, 2024
anovikov-el
previously approved these changes
Oct 2, 2024
anovikov-el
reviewed
Oct 23, 2024
anovikov-el
previously approved these changes
Nov 3, 2024
anovikov-el
previously approved these changes
Nov 21, 2024
anovikov-el
reviewed
Dec 16, 2024
providers/google_provider/gcp.go
Outdated
| if err != nil { | ||
| var respError *apierror.APIError | ||
| if errors.As(err, &respError) && respError.GRPCStatus().Code().String() == gRPCErrorPermissionDenied { | ||
| zap.S().Warnf("permission denied to get access for GCP secrets values") |
There was a problem hiding this comment.
permission denied to get access to GCP secrets values
providers/google_provider/gcp.go
Outdated
| if err != nil { | ||
| var respError *apierror.APIError | ||
| if errors.As(err, &respError) && respError.GRPCStatus().Code().String() == gRPCErrorPermissionDenied { | ||
| zap.S().Warnf("permission denied to add to secret %s value", keyName) |
There was a problem hiding this comment.
permission denied to add GCP secret %s value
vadim-bogdanovsky
approved these changes
Dec 16, 2024
anovikov-el
previously approved these changes
Dec 16, 2024
vadim-bogdanovsky
approved these changes
Dec 16, 2024
anovikov-el
previously approved these changes
Dec 17, 2024
vadim-bogdanovsky
approved these changes
Dec 17, 2024
vadim-bogdanovsky
approved these changes
Dec 17, 2024
anovikov-el
previously approved these changes
Dec 17, 2024
vadim-bogdanovsky
approved these changes
Dec 18, 2024
vadim-bogdanovsky
approved these changes
Dec 18, 2024
vadim-bogdanovsky
approved these changes
Dec 18, 2024
vadim-bogdanovsky
approved these changes
Dec 18, 2024
anovikov-el
previously approved these changes
Dec 18, 2024
anovikov-el
approved these changes
Dec 19, 2024
vadim-bogdanovsky
approved these changes
Dec 19, 2024
apanasiuk-el
deleted the
feature/RMK-29-refactor-internal-logic-of-rmk-cluster-provider-initialization-and-selection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.