-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ALPN support for the Deno adapter. #199
Conversation
My test file ( import {createClient} from "./edgedb-deno/mod.ts";
async function main() {
let conn = createClient({
dsn: "_localdev", tlsSecurity: "insecure",
//tlsCAFile: '/home/yury/.local/share/edgedb/_localdev/edbtlscert.pem'
});
console.log('=1');
await conn.ensureConnected();
console.log('=2');
console.log(await conn.querySingle('select 32323'));
console.log('=3');
}
main() I was running it with yarn compileForDeno && \
../../deno/target/debug/deno run --allow-all --unstable \
--unsafely-ignore-certificate-errors t.ts Assuming that Deno was cloned into the To build Deno locally I followed https://deno.land/[email protected]/contributing/building_from_source. It's basically just cloning the repo with all submodules and running |
@jaclarke James, please take a look at this. Specifically check if we need any more APIs for a complete edgedb-deno client. The Lastly, by default Deno tries to connect to |
The client will mostly work without these, but to fully match the behaviour of edgedb-js it looks like we will need a few more:
|
For me I'm assuming |
Looks like that won't happen: denoland/deno#1371 |
I've filed a PR to add ALPN support: denoland/deno#12786 |
…enamed `--tls-cert-mode` option
Depends on edgedb/deno@a95fef9