Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlmodel #564

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Sqlmodel #564

merged 2 commits into from
Jan 28, 2025

Conversation

vpetrovykh
Copy link
Member

There are two commits. The first one is mostly tweaks based on the feedback about the ORM schema generators. The second one adds SQLModel schema generator (that's very similar to SQLAlchemy).

@vpetrovykh vpetrovykh requested a review from a team January 21, 2025 18:52
@vpetrovykh vpetrovykh force-pushed the sqlmodel branch 2 times, most recently from 726dc92 to f13893b Compare January 21, 2025 19:01
Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything in specific you want me to look closely at? I mostly skimmed this, since it is very similar to sqlalchemy

Replace "backlink_via_" pattern with "back_to_" and
"follow_linkt_back_to_" naming convention for backlinks.
This is similar to SQLAlchemy model generator, but the results are
SQLModels instead.
@vpetrovykh vpetrovykh merged commit a61960f into master Jan 28, 2025
64 checks passed
@vpetrovykh vpetrovykh deleted the sqlmodel branch January 28, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants