Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

feat: Make list a default command operation #362

Closed
wants to merge 1 commit into from

Conversation

difince
Copy link
Contributor

@difince difince commented Jan 13, 2021

Signed-off-by: Diana Atanasova [email protected]

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-cli/blob/master/.github/Contributing.md.

What is the current behavior?

Issue Number:

Closes: #336

What is the new behavior?

Make list default command operation for all commands, but still keep the
list as an available operation
Example list all devices could be called in two ways:

edgex-cli device
edgex-cli device list

Does this PR introduce a breaking change?

  • Yes
  • [X ] No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

Make list default command operation for all commands, but still keep the
list as an available operation
Example list all devices could be called in two ways:
> edgex-cli device
> edgex-cli device list

Closes: edgexfoundry#336

Signed-off-by: Diana Atanasova <[email protected]>
@difince difince requested review from mkbhanda and tonyespy January 13, 2021 12:34
@difince difince self-assigned this Jan 13, 2021
@codecov-io
Copy link

Codecov Report

Merging #362 (582081a) into master (4e4b63e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   14.51%   14.51%           
=======================================
  Files           3        3           
  Lines          62       62           
=======================================
  Hits            9        9           
  Misses         53       53           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e4b63e...582081a. Read the comment docs.

@difince difince marked this pull request as draft January 13, 2021 14:17
@difince difince closed this Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default command operation should be list
3 participants