Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

docs(snap): add snap README.md #425

Merged
merged 1 commit into from
Dec 3, 2021
Merged

docs(snap): add snap README.md #425

merged 1 commit into from
Dec 3, 2021

Conversation

siggiskulason
Copy link

This PR adds a missing README.md file for snap deployment

Signed-off-by: Siggi Skulason [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-cli/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) N/A
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

N/A

New Dependency Instructions (If applicable)

Signed-off-by: Siggi Skulason <[email protected]>
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@siggiskulason siggiskulason requested review from MonicaisHer and removed request for tonyespy December 3, 2021 16:17
Copy link
Contributor

@MonicaisHer MonicaisHer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MonicaisHer MonicaisHer merged commit 913a271 into edgexfoundry:main Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants