-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Add section Configure ADD_PROXY_ROUTE of API Gateway #181
doc: Add section Configure ADD_PROXY_ROUTE of API Gateway #181
Conversation
cc: @hutchic, I can't find you in the dropdown list of reviewer for some reason... |
7003d4f
to
78ff407
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
IMO the text is understandable and easy to follow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some very small grammar changes overall LGTM 👍
6d819d3
to
0e03c5b
Compare
Thanks Colin for the feedback, fixed. |
Add a new section for configuring `ADD_PROXY_ROUTE` environment variable in edgex-proxy service Closes: edgexfoundry#171 Signed-off-by: Jim Wang <[email protected]>
0e03c5b
to
06fa3b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: edgex-jenkins <[email protected]>
Signed-off-by: edgex-jenkins <[email protected]>
Add a new section for configuring
ADD_PROXY_ROUTE
environment variable in edgex-proxy serviceCloses: #171
Signed-off-by: Jim Wang [email protected]
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #171
What has been updated?
Add a new document section for adding proxy Kong routes for additional services
Are there any specific instructions or things that should be known prior to reviewing?
Other information