Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add section Configure ADD_PROXY_ROUTE of API Gateway #181

Merged

Conversation

jim-wang-intel
Copy link
Contributor

Add a new section for configuring ADD_PROXY_ROUTE environment variable in edgex-proxy service

Closes: #171

Signed-off-by: Jim Wang [email protected]

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #171

What has been updated?

Add a new document section for adding proxy Kong routes for additional services

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@jim-wang-intel jim-wang-intel added documentation geneva 2-medium priority denoting issues with cross-cutting project impact app-services subsystem_affected for application services security-services labels Jul 8, 2020
@jim-wang-intel jim-wang-intel self-assigned this Jul 8, 2020
@jim-wang-intel
Copy link
Contributor Author

cc: @hutchic, I can't find you in the dropdown list of reviewer for some reason...

@jim-wang-intel jim-wang-intel force-pushed the add-proxy-routes-171 branch from 7003d4f to 78ff407 Compare July 8, 2020 23:57
difince
difince previously approved these changes Jul 9, 2020
Copy link
Contributor

@difince difince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
IMO the text is understandable and easy to follow

hutchic
hutchic previously approved these changes Jul 10, 2020
Copy link
Member

@hutchic hutchic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some very small grammar changes overall LGTM 👍

docs_src/microservices/security/Ch-APIGateway.md Outdated Show resolved Hide resolved
docs_src/microservices/security/Ch-APIGateway.md Outdated Show resolved Hide resolved
docs_src/microservices/security/Ch-APIGateway.md Outdated Show resolved Hide resolved
@jim-wang-intel jim-wang-intel dismissed stale reviews from hutchic and difince via 6d819d3 July 10, 2020 17:36
@jim-wang-intel jim-wang-intel force-pushed the add-proxy-routes-171 branch 2 times, most recently from 6d819d3 to 0e03c5b Compare July 10, 2020 17:38
@jim-wang-intel
Copy link
Contributor Author

some very small grammar changes overall LGTM +1

Thanks Colin for the feedback, fixed.

 Add a new section for configuring `ADD_PROXY_ROUTE` environment variable in edgex-proxy service

 Closes: edgexfoundry#171

Signed-off-by: Jim Wang <[email protected]>
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit a20dcf7 into edgexfoundry:master Jul 20, 2020
edgex-jenkins added a commit that referenced this pull request Jul 20, 2020
edgex-jenkins added a commit that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-medium priority denoting issues with cross-cutting project impact app-services subsystem_affected for application services documentation geneva security-services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to add additional services to API Gateway
5 participants