Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated device service pages under microservices tab #209

Merged

Conversation

jpwhitemn
Copy link
Member

Signed-off-by: Jim White [email protected]

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

n/a

Issue Number:
none

What has been updated?

updated device services pages under microservices tab

Are there any specific instructions or things that should be known prior to reviewing?

none

Other information

description: "Generate random int8 value"
properties:
value:
{ type: "Int8", readWrite: "R", defaultValue: "0" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just opened an issue for this
edgexfoundry/device-virtual-go#123

The readWrite field should be RW, because it supports Put command

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this remaining one is really minor

docs_src/microservices/device/virtual/Ch-VirtualDevice.md Outdated Show resolved Hide resolved
docs_src/microservices/device/virtual/Ch-VirtualDevice.md Outdated Show resolved Hide resolved
docs_src/microservices/device/Ch-DeviceServices.md Outdated Show resolved Hide resolved
@jpwhitemn jpwhitemn requested a review from cloudxxx8 August 3, 2020 19:51
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpwhitemn jpwhitemn merged commit 8925862 into edgexfoundry:master Aug 4, 2020
@jpwhitemn jpwhitemn deleted the upd-microservices-device-services branch August 4, 2020 16:01
edgex-jenkins added a commit that referenced this pull request Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants