Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat (UI): added sticky headings #164

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feat (UI): added sticky headings #164

wants to merge 2 commits into from

Conversation

parmisan
Copy link
Contributor

@parmisan parmisan commented Oct 20, 2024 •
edited
Loading

Problem

https://github.com/editor-js/table/issues/163

Solution

  • added position sticky for headings

resolves #163
image

@parmisan parmisan changed the title added sticky headers Feat (UI): added sticky headings Oct 21, 2024
e11sy
e11sy reviewed Oct 23, 2024
View reviewed changes
src/styles/table.pcss Outdated
position: sticky;
top: 0px;
z-index: 2;
background-color: #fff;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

background color should respect --color-background variable

neSpecc
neSpecc requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the Add Column button sticky too

And update a patch version

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc requested changes

@e11sy e11sy e11sy approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature (UI): pozition sticky for headings
3 participants
@parmisan @neSpecc @e11sy