Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement versioning changes #17

Merged
merged 1 commit into from
May 14, 2020
Merged

Implement versioning changes #17

merged 1 commit into from
May 14, 2020

Conversation

cxw42
Copy link
Member

@cxw42 cxw42 commented Apr 8, 2020

I propose these changes to implement editorconfig/editorconfig-vote#11. I look forward to any comments and questions!

  • The versioning information is a new section at the end.
  • I added a "definitions" section at the beginning to make the versioning section clearer.
  • I did some minor cleanup (spelling, table header)

NOTE: Not all the changes approved by vote 11 are in the specification. Items still open, to be done after this PR is merged, are:

  • bump editorconfig-core-test to v0.13 to mark this change
  • update the core tests (or accept a PR) here to permit major.minor version numbers (no patch)

Thanks for considering this PR, and for voting in favor of my requests!

xuhdev
xuhdev reviewed Apr 8, 2020
View reviewed changes
Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! And thanks for the wording and grammar fixes!

index.rst Show resolved Hide resolved
index.rst Outdated Show resolved Hide resolved
index.rst Show resolved Hide resolved
@cxw42
Implement versioning changes
73f98a1 
- Make changes specified by editorconfig/editorconfig-vote#11
- Add definitions of terms to make the versioning section clearer
- Minor cleanup
@cxw42
Copy link
Member Author

cxw42 commented Apr 10, 2020

Updated, and rebased on master

@cxw42
Copy link
Member Author

cxw42 commented Apr 17, 2020

@editorconfig/board-member Comments?

@florianb
Copy link
Member

Again - great work! Thanks!

I have a question regarding the -b option, what will it exactly do, or what is meant with processing a version number? I guess i missed something - so sorry for any confusion.. 😸

@cxw42
Copy link
Member Author

cxw42 commented Apr 17, 2020

-b VER means "behave as if you were version VER". I don't know if we have any tests for that yet. Once we have a better definition of versions, we can meaningfully add tests.

@cxw42 cxw42 mentioned this pull request Apr 18, 2020
Closed
@cxw42
Copy link
Member Author

cxw42 commented May 14, 2020

Ping

Mpdreamz
Mpdreamz requested changes May 14, 2020
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small notes, thanks for leading this effort!

index.rst Show resolved Hide resolved
index.rst Show resolved Hide resolved
xuhdev
xuhdev approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no further comments. Feel free to merge once everyone is happy.

Mpdreamz
Mpdreamz approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking this as well LGTM 👍

@cxw42
Copy link
Member Author

cxw42 commented May 14, 2020

Thanks to all! @xuhdev I don't have the access to merge - would you please? Thanks!

@xuhdev xuhdev merged commit 437d266 into editorconfig:master May 14, 2020
@xuhdev
Copy link
Member

xuhdev commented May 14, 2020

Done!

@cxw42 cxw42 mentioned this pull request May 15, 2020
Open
@cxw42 cxw42 deleted the vote-11 branch May 15, 2020 01:55
@cxw42 cxw42 mentioned this pull request May 15, 2020
Open
@cxw42 cxw42 mentioned this pull request May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianb florianb florianb left review comments

@Mpdreamz Mpdreamz Mpdreamz approved these changes

@xuhdev xuhdev xuhdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cxw42 @florianb @xuhdev @Mpdreamz