Skip to content

Commit

Permalink
Issue 104: stats bug for cmd_get
Browse files Browse the repository at this point in the history
  • Loading branch information
Trond Norbye authored and dustin committed Oct 29, 2009
1 parent ac37e81 commit b1001be
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 0 deletions.
1 change: 1 addition & 0 deletions memcached.c
Original file line number Diff line number Diff line change
Expand Up @@ -2618,6 +2618,7 @@ static inline void process_get_command(conn *c, token_t *tokens, size_t ntokens,
} else {
pthread_mutex_lock(&c->thread->stats.mutex);
c->thread->stats.get_misses++;
c->thread->stats.get_cmds++;
pthread_mutex_unlock(&c->thread->stats.mutex);
MEMCACHED_COMMAND_GET(c->sfd, key, nkey, -1, 0);
}
Expand Down
24 changes: 24 additions & 0 deletions t/issue_104.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#!/usr/bin/perl

use strict;
use Test::More tests => 6;
use FindBin qw($Bin);
use lib "$Bin/lib";
use MemcachedTest;

my $server = new_memcached();
my $sock = $server->sock;

# first get should miss
print $sock "get foo\r\n";
is(scalar <$sock>, "END\r\n", "get foo");

# Now set and get (should hit)
print $sock "set foo 0 0 6\r\nfooval\r\n";
is(scalar <$sock>, "STORED\r\n", "stored foo");
mem_get_is($sock, "foo", "fooval");

my $stats = mem_stats($sock);
is($stats->{cmd_get}, 2, "Should have 2 get requests");
is($stats->{get_hits}, 1, "Should have 1 hit");
is($stats->{get_misses}, 1, "Should have 1 miss");

0 comments on commit b1001be

Please sign in to comment.