Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCP JSON license injection regression bug (ZIP lib, stream event) #2746

Closed
danielweck opened this issue Jan 6, 2025 · 1 comment
Closed
Assignees

Comments

@danielweck
Copy link
Member

danielweck commented Jan 6, 2025

https://www.edrlab.org/readium-lcp/testing-readium-lcp-compliant-devices/

===>

https://www.edrlab.org/public/feed/the-waste-land/the-waste-land.lcpl

===>

Uncaught Exception:
Error: cannot add entries after calling end()
at shouldIgnoreAdding (readium-desktop/node_modules/yazl/index.js:303:25)
at ZipFile.addReadStreamLazy (readium-desktop/node_modules/yazl/index.js:68:7)
at ZipFile.addReadStream (readium-desktop/node_modules/yazl/index.js:54:8)
at readium-desktop/node_modules/r2-utils-js/dist/es8-es2017/src/_utils/zip/zipInjector.js:53:29
at ZipFile.openReadStreamLowLevel (readium-desktop/node_modules/yauzl/index.js:511:3)
at readium-desktop/node_modules/yauzl/index.js:461:10
at readium-desktop/node_modules/yauzl/index.js:543:16
at readium-desktop/node_modules/yauzl/index.js:772:5
at readium-desktop/node_modules/yauzl/fd-slicer.js:33:7
at FSReqCallback.wrapper [as oncomplete] (node:fs:682:5)

===> non-fatal crash, but causes EPUB to successfully contain META-INF/license.lcpl but META-INF/encryption.xml is removed!!

@danielweck
Copy link
Member Author

Related commit (no behaviour change, just better event tracing and code comments): 261342b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant