Adds "(online)" mention to the link that will change user context by opening the browser #2722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(becomes Close this reading window (back to bookshelf)) closes #2696
So the users knows that will open a browser and change the context.
gautierchomel
changed the title
|
Note that this PR inherited the previous branch commit about the already merged bookshelf label. Not sure how to avoid that without having to recreate a new branch. |
|
Perhaps another option could be to use a globe icon next to the text to indicate that is it a web resource? E.g. "About Thorium 🌎". It could use one of the globe icons that are already used in Thorium: https://github.com/edrlab/thorium-reader/blob/ded9817fcd660bf4c46defd5eb447e0df66d3057/src/renderer/assets/icons/globe-icon.svg or https://github.com/edrlab/thorium-reader/blob/ded9817fcd660bf4c46defd5eb447e0df66d3057/src/renderer/assets/icons/globe-icon-bold.svg Although it would still require the extra "(online)" text for screen reader users? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's an alternate quick fix for #2717 while we continue discussions about the necessity of having an in-app about panels for short contextual information.