Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageHeader (connected #12) #51

Merged
merged 5 commits into from
Nov 1, 2016
Merged

PageHeader (connected #12) #51

merged 5 commits into from
Nov 1, 2016

Conversation

PolarWooolf
Copy link
Contributor

#12

@PolarWooolf PolarWooolf changed the title PageHeader PageHeader (connected #12) Oct 31, 2016
Copy link
Contributor

@sergeyt sergeyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

мержу, почистим код потом, давай другую задачу делать


class Root extends React.Component<{}, {}> {
render() {
return Routes;
}
}

render(<PageHeader/>, document.getElementById('header'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я думаю PageHeader должен рисоваться в каждой конкретной странице, например его не должно быть на странице логина.

<Menu><Container>{container}</Container></Menu>
);
/*
<Container>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тебе этот код нужен? предлагаю удалить если не нужен уже

@sergeyt sergeyt merged commit 11ebfd8 into master Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants