-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: solve error check k8s workflow main #102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ian2012
approved these changes
May 15, 2024
@marbonilla remember to run the workflow on pushes to main on:
push:
branches: main |
@marbonilla @Ian2012 Why did it work in previous builds? |
@jfavellar90 I'm guessing that it might be because the utilities used for testing aren't pinned (
kubeconform broke the thing.
|
I would suggest a couple of things here:
|
I'm fine with that approach |
marbonilla
force-pushed
the
mar/fix-workflow
branch
from
May 22, 2024 17:01
c333b9b
to
8b681f7
Compare
Ian2012
approved these changes
May 22, 2024
jfavellar90
reviewed
May 22, 2024
jfavellar90
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR include a fix to the
Check k8s manifests
workflow to resolve the error: