Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solve error check k8s workflow main #102

Merged
merged 3 commits into from
May 24, 2024
Merged

fix: solve error check k8s workflow main #102

merged 3 commits into from
May 24, 2024

Conversation

marbonilla
Copy link
Contributor

Description

This PR include a fix to the Check k8s manifests workflow to resolve the error:

invalid value "latest" for flag -kubernetes-version: latest is not a valid version. Valid values are "master" (default) or full version x.y.z (e.g. "1.27.2")

@marbonilla marbonilla requested a review from a team as a code owner May 15, 2024 19:45
@Ian2012
Copy link
Contributor

Ian2012 commented May 15, 2024

@marbonilla remember to run the workflow on pushes to main

on:
    push:
       branches: main

@jfavellar90
Copy link
Member

@marbonilla @Ian2012 Why did it work in previous builds?

@MoisesGSalas
Copy link
Member

@jfavellar90 I'm guessing that it might be because the utilities used for testing aren't pinned (

) and a new release of kubeconform broke the thing.

@jfavellar90
Copy link
Member

I would suggest a couple of things here:

  • Could we add a step in the validation job to print the version of Kubernetes, Kustomize, and Kubeconform we are running the tests against? This can help to debug when the action fails.
  • Could we pin the Kubeconform version? The latest one is v0.6.6. We can update the version in the action every time we release the version compatible with the new Tutor version.

@marbonilla @Ian2012 @MoisesGSalas

@MoisesGSalas
Copy link
Member

I'm fine with that approach

@marbonilla marbonilla merged commit e6a4e91 into main May 24, 2024
4 checks passed
@marbonilla marbonilla deleted the mar/fix-workflow branch May 24, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants