-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: render global environment outside tutor-env #5
Conversation
090ff42
to
ad5c31e
Compare
version: {{ DRYDOCK_PROMETHEUS_VERSION }} | ||
releaseName: prometheus | ||
includeCRDs: true | ||
{%- if DRYDOCK_PROMETHEUS_VALUES | default(false) %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking of not using default here and instead having them in the defaults.yml file? That way we can refer to that file to know what variables are available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! :)
9f783b5
to
3e1af40
Compare
15bcd83
to
890f233
Compare
hey! what do you think now? @jfavellar90 @MoisesGSalas |
881f7d4
to
d9b7c5c
Compare
Description
This PR adds a new manifest builder that generates manifests outside the usual tutor environment, which are meant to be used to create global resources for a cluster.
How to test
Generate a drydock environment using a reference with the GlobalManifests builder, e.g:
After running
tutor drydock save -r drydock-reference.yml
, a new env called global-env will be generated with the customization file rendered