Fixed issue with wrong active value for widths smalller than smallest breakpoint #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2016 11:28
eduardoboucas
requested changes
Oct 31, 2016
| @@ -30,6 +30,9 @@ | |||
| breakpoints = JSON.parse(removeQuotes(data)); | |||
| } catch (err) {} | |||
| } | |||
| else { | |||
There was a problem hiding this comment.
Do you mind putting the else on the previous line, next to the closing curly brace, as per the rest of the file?
Also, should it return null instead of false?
There was a problem hiding this comment.
Hey,
I'll update formatting in a sec.
When it comes to return value false is the default value for breakpoints variable so i thought it makes more sense. Shall i change it anyway?
There was a problem hiding this comment.
Sorry, you're right! I haven't looked at this code for a while...
There was a problem hiding this comment.
I pushed updated version with fixed formatting.
eduardoboucas
approved these changes
Oct 31, 2016
|
Thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I found one issue with your library concerning screen widths below smallest breakpoint.
In situation when my smallest breakpoint was set to 480px:
$breakpoints: (phone: 480px, tablet: 768px, tablet-large: 906px, desktop: 1024px, desktop-large: 1200px);if i resize the window to a width smaller than 480px from anything larger (let's say >=desktop) the CSS attributes on document.body:after (default element) are being cleared. The JS library is still keeping the old copy of CSS attributes in the memory and reports that my current breakpoint is still 'desktop'.
Please have a look and let me know what you think.
Cheers,
Tomasz