Skip to content
This repository has been archived by the owner on Jun 2, 2021. It is now read-only.

Pin eslint-plugin-jsx-a11y to 6.0.3. #42

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

iloveagent57
Copy link
Member

There's a bug in [email protected] - https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/454 - that's causing eslint to spit out a bunch of unintended errors. This PR pins eslint-plugin-jsx-a11y to 6.0.3 (minor bump from 6.0.2). Previously, the "^6.0.2" dependency string made it so that the latest package with the same major version was installed, i.e. 6.1.0, which we don't want.

@iloveagent57 iloveagent57 requested a review from arizzitano July 5, 2018 17:32
Copy link
Contributor

@arizzitano arizzitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @iloveagent57! Would you mind also bumping the version of eslint-config-edx in package.json and package-lock.json so we can cut a patch release?

@iloveagent57 iloveagent57 force-pushed the aed/pin-eslint-plugin-jsx-a11y branch from 77ffa42 to da90903 Compare July 5, 2018 17:58
@iloveagent57
Copy link
Member Author

@arizzitano done!

@iloveagent57 iloveagent57 merged commit 0b22940 into master Jul 5, 2018
@iloveagent57 iloveagent57 deleted the aed/pin-eslint-plugin-jsx-a11y branch July 5, 2018 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants