Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to the new version of brand-openedx in the new scope #34

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

brian-smith-tcril
Copy link
Contributor

Part of openedx/axim-engineering#23

This updates the @edx/brand alias to point to the brand-openedx package at
the openedx scope. This does not impact imports because this package is used
via an alias.

@openedx-webhooks
Copy link

Thanks for your pull request, but this repo does not accept outside contributions unless they are under contract. If you think this is an error, please contact @nedbat.

@rijuma
Copy link
Member

rijuma commented Dec 23, 2024

Hello @brian-smith-tcril. Sorry this PR sat here for so long. Do you still want to merge it?

If so, please fix the conflicts and since you are updating it, please bump the brand-openedx to the last version @openedx/brand-openedx@^1.2.3.

Thank you.

@brian-smith-tcril brian-smith-tcril force-pushed the update-brand-scope branch 3 times, most recently from 82666e8 to 608d846 Compare January 6, 2025 15:00
@brian-smith-tcril
Copy link
Contributor Author

@rijuma I have rebased on latest main, updated the line in package.json to ^1.2.3, and run npm install to update package-lock.json.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (ce3677d) to head (4df3d37).
Report is 29 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #34       +/-   ##
===========================================
+ Coverage   81.36%   92.00%   +10.63%     
===========================================
  Files          13       26       +13     
  Lines         220      350      +130     
  Branches       30       75       +45     
===========================================
+ Hits          179      322      +143     
+ Misses         39       25       -14     
- Partials        2        3        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rijuma
Copy link
Member

rijuma commented Jan 21, 2025

@rijuma I have rebased on latest main, updated the line in package.json to ^1.2.3, and run npm install to update package-lock.json.

Hey. So sorry I missed it. Would you please update it one more time since the branch is out of date? I'll promise to merge it first thing tomorrow.

@rijuma rijuma merged commit d1e8529 into edx:main Jan 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants