Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused parameter. #1735

Merged
merged 1 commit into from
Mar 13, 2024
Merged

chore: remove unused parameter. #1735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions dataeng/jobs/analytics/RetirementJobs.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ class RetirementJobs{
wrappers common_wrappers(allVars)
parameters secure_scm_parameters(allVars)
parameters {
stringParam('TUBULAR_BRANCH', 'master', 'Repo branch for the tubular scripts.')
stringParam('PLATFORM_BRANCH', 'origin/2u/release', 'Branch from the edx-platform repository. For tags use tags/[tag-name].')
stringParam('ENVIRONMENT', '', 'edx environment which contains the user in question, in ENVIRONMENT-DEPLOYMENT format.')
stringParam('RETIREMENT_USERNAME', '', 'Current username of learner to retire.')
Expand Down Expand Up @@ -146,7 +145,6 @@ class RetirementJobs{
}
}
parameters {
stringParam('TUBULAR_BRANCH', 'master', 'Repo branch for the tubular scripts.')
stringParam('ENVIRONMENT', '', 'edx environment which contains the user in question, in ENVIRONMENT-DEPLOYMENT format.')
stringParam('COOL_OFF_DAYS', '14', 'Number of days a learner should be in the retirement queue before being actually retired.')
stringParam('USER_COUNT_ERROR_THRESHOLD', '251', 'If more users than this number are returned we will error out instead of retiring.')
Expand Down Expand Up @@ -204,7 +202,6 @@ class RetirementJobs{
unstable('UNSTABLE')
}
parameters {
predefinedProp('TUBULAR_BRANCH', '${TUBULAR_BRANCH}')
predefinedProp('PLATFORM_BRANCH', '${PLATFORM_BRANCH}')
predefinedProp('ENVIRONMENT', '${ENVIRONMENT}')
}
Expand Down Expand Up @@ -286,7 +283,6 @@ class RetirementJobs{
}

parameters {
stringParam('TUBULAR_BRANCH', 'master', 'Repo branch for the tubular scripts.')
stringParam('ENVIRONMENT', '', 'edx environment which contains the user in question, in ENVIRONMENT-DEPLOYMENT format.')
stringParam('RETIREMENT_JOBS_MAILING_LIST', allVars.get('RETIREMENT_JOBS_MAILING_LIST'), 'Space separated list of emails to send notifications to.')
stringParam('PLATFORM_BRANCH', 'origin/2u/release', 'Branch from the edx-platform repository. For tags use tags/[tag-name].')
Expand Down Expand Up @@ -391,7 +387,6 @@ class RetirementJobs{
}

parameters {
stringParam('TUBULAR_BRANCH', 'master', 'Repo branch for the tubular scripts.')
stringParam('ENVIRONMENT', '', 'edx environment which contains the user in question, in ENVIRONMENT-DEPLOYMENT format.')
stringParam('AGE_IN_DAYS', '60', 'Number of days to keep partner reports.')
stringParam('RETIREMENT_JOBS_MAILING_LIST', allVars.get('RETIREMENT_JOBS_MAILING_LIST'), 'Space separated list of emails to send notifications to.')
Expand Down Expand Up @@ -474,7 +469,6 @@ class RetirementJobs{
}

parameters {
stringParam('TUBULAR_BRANCH', 'master', 'Repo branch for the tubular scripts.')
stringParam('ENVIRONMENT', '', 'edx environment which contains the user in question, in ENVIRONMENT-DEPLOYMENT format.')
stringParam('START_DATE', '', 'Find users that requested deletion starting with this day (YYYY-MM-DD).')
stringParam('END_DATE', '', 'Find users that requested deletion ending with this day (YYYY-MM-DD). To select one day make the start and end dates the same.')
Expand Down
Loading