Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-384 added reference to core module in pom.xml #386

Merged
merged 2 commits into from
Oct 13, 2018

Conversation

Casva
Copy link
Contributor

@Casva Casva commented Oct 13, 2018

#384 Added reference to andhow core to this pom file

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov
Copy link

codecov bot commented Oct 13, 2018

Codecov Report

Merging #386 into master will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage    72.2%   72.57%   +0.37%     
==========================================
  Files         120      119       -1     
  Lines        3511     3493      -18     
  Branches      568      564       -4     
==========================================
  Hits         2535     2535              
+ Misses        770      752      -18     
  Partials      206      206
Impacted Files Coverage Δ
.../main/java/org/yarnandtail/compile/TestSource.java 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b480ac...06a6d93. Read the comment docs.

@eeverman
Copy link
Owner

eeverman commented Oct 13, 2018

Thanks for the contribution, @Casva
There actually a bit more to this task:

  • The class org.yarnandtail.compile.IOUtil actually needs to be removed/deleted.
  • The one place where the deleted class is used needs to be updated to use the other IOUtil class.

Sorry if the task was not worded clearly.

@Casva
Copy link
Contributor Author

Casva commented Oct 13, 2018

Ah my mistake @eeverman I misread.

Hope everything is good now! 😄

Copy link
Owner

@eeverman eeverman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done and thank you for the merge request!

If this project looks interesting to you, please give it a star ✨

AndHow is intended to simplify and structure application configuration - If you know of a project that might benefit from it, I'm willing to try to integrate it.

@eeverman eeverman merged commit 309763a into eeverman:master Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants