Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ‘©πŸ»β€πŸŽ€ Add mobile styles for user action section #70

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

mrushkova
Copy link
Collaborator

@mrushkova mrushkova commented Jun 10, 2024


@mrushkova mrushkova requested a review from b-tarczynski June 10, 2024 12:47
Copy link

netlify bot commented Jun 10, 2024

βœ… Deploy Preview for devcon-raffle ready!

Name Link
πŸ”¨ Latest commit 48a9a80
πŸ” Latest deploy log https://app.netlify.com/sites/devcon-raffle/deploys/6667ec69e59ac800081924ef
😎 Deploy Preview https://deploy-preview-70--devcon-raffle.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@b-tarczynski b-tarczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, noticed 2 things:

  • winner flow isn't adjusted for mobile (added a task for that here)
  • there is weird button resizing when using desktop version - might be due to how we make buttons wide

@b-tarczynski b-tarczynski enabled auto-merge (squash) June 11, 2024 06:19
@b-tarczynski b-tarczynski merged commit b6fd919 into master Jun 11, 2024
4 of 5 checks passed
@b-tarczynski b-tarczynski deleted the maria/mobile-action branch June 11, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants