Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate code to React #4

Closed
4 tasks done
effortlessmountain opened this issue Mar 9, 2020 · 1 comment
Closed
4 tasks done

Migrate code to React #4

effortlessmountain opened this issue Mar 9, 2020 · 1 comment
Assignees
@effortlessmountain
Labels
enhancement New feature or request
Milestone
non-hostile-ui

Comments

@effortlessmountain
Copy link
Owner

effortlessmountain commented Mar 9, 2020 •
edited
Loading

Acceptance Criteria:

  • App retains functionality
  • App has automated tests

Tasks

  • Migrate asset rendering
  • Migrate editor
  • Migrate scaling/example selection
  • Migrate rest of app
@effortlessmountain effortlessmountain added the enhancement New feature or request label Mar 9, 2020
@effortlessmountain effortlessmountain self-assigned this Mar 19, 2020
effortlessmountain added a commit that referenced this issue Mar 19, 2020
@effortlessmountain
(#4) migrate to create-react-app typescript tooling
82a0b58
effortlessmountain added a commit that referenced this issue Mar 23, 2020
@effortlessmountain
(#4) clean up index.html
ceb3624
@effortlessmountain effortlessmountain added this to the non-hostile-ui milestone Mar 23, 2020
effortlessmountain added a commit that referenced this issue Mar 23, 2020
@effortlessmountain
(#4) (wip) mostly bring Asset into React
ae86c53
effortlessmountain added a commit that referenced this issue Mar 26, 2020
@effortlessmountain
(#4) reach text parity with asset display (icon still needs dimension…
838faf4 
…s set)
effortlessmountain added a commit that referenced this issue Apr 5, 2020
@effortlessmountain
(#4) (wip) start switching to defined SVG tag instead of dangerouslyS…
fbc4e82 
…etHtml

This also fixes the SVG sizing issue of download images in Chrome
effortlessmountain added a commit that referenced this issue Apr 8, 2020
@effortlessmountain
(#4) begin mapping the svg to v2 doc version
8bb3131
effortlessmountain added a commit that referenced this issue Apr 14, 2020
@effortlessmountain
(#4) map more svg properties between versions
b3cdb11
effortlessmountain added a commit that referenced this issue Apr 14, 2020
@effortlessmountain
(#4) plug in asset updating code
9bbdc35
effortlessmountain added a commit that referenced this issue Apr 17, 2020
@effortlessmountain
(#4) fix scaling of asset in a re-render-the-world way
df3e027
effortlessmountain added a commit that referenced this issue Apr 19, 2020
@effortlessmountain
(#4 #7) improve file upload by removing prompt and styling a tiny bit
ca3050c
effortlessmountain added a commit that referenced this issue Apr 19, 2020
@effortlessmountain
(#4) fix icon issues
703d20b
@effortlessmountain effortlessmountain mentioned this issue Apr 19, 2020
Merged
effortlessmountain added a commit that referenced this issue Apr 21, 2020
@effortlessmountain
(#4) convert perhaps the biggest slice possible to React without conv…
fa4ef5c 
…erting the entire app

Converting just the textarea and update button would have been a more
sensible step.
effortlessmountain added a commit that referenced this issue Apr 22, 2020
@effortlessmountain
(#4) bring entire app under App component
0c509bb
effortlessmountain added a commit that referenced this issue Apr 27, 2020
@effortlessmountain
(#4) convert routing and asset image download to React
93ce68f
@effortlessmountain
Copy link
Owner Author

App migrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@effortlessmountain effortlessmountain

Labels
enhancement New feature or request
Projects
None yet
Milestone
non-hostile-ui
Development

No branches or pull requests
1 participant
@effortlessmountain