feat: remove fileTransport from consoleLogger #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (this.options.errorFile) { | ||
| const fileTransport = new FileTransport({ | ||
| file: this.options.errorFile, |
There was a problem hiding this comment.
master 的日志不再输出到 common error 了？那监控还得加上对 stderr 的日志了，这个日志目前监控平台是没有默认加的，要每个应用加，不太好吧。
There was a problem hiding this comment.
好像也没法写得 common error，要不然 master 也得接收 reload log 的事件。。。
There was a problem hiding this comment.
这个挺麻烦的，原因是 master 不会去 load config 了，所以就无法配置了。
但想想也对，master 进程不应该去管理这个，我们现在有些错误其实也是在 stderr 的，比如 master 意外退出，感觉监控 stderr 更加好。
There was a problem hiding this comment.
嗯，到时候得找找监控的同学，看看能否默认将 stderr 也监控了。
|
+1 |
|
这个怎么发呢？算 minor？ |
|
因为原来的实现其实是有问题的，会导致写文件失败，那个打开的文件已经被删除了。 |
|
发 minor |
|
发 minor 吧 |
|
1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relate eggjs/egg#33