-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: translation for basic plugin #2166
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2166 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 29 29
Lines 749 749
=======================================
Hits 746 746
Misses 3 3 Continue to review full report at Codecov.
|
docs/source/en/basics/plugin.md
Outdated
* What are the differences/relationship between middleware and plugins? | ||
* How do I use a plugin? | ||
* How do I write a plug-in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plug-in ->plugin
docs/source/en/basics/plugin.md
Outdated
To sum up, we need a more powerful mechanism to manage, orchestrate those relatively independent business logic. | ||
|
||
### The relationship between middleware and plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
中文是:"中间件、插件、应用的关系", 漏了一个 ”应用“
docs/source/en/basics/plugin.md
Outdated
|
||
* `{Boolean} enable` - Whether to enable this plugin, the default is true | ||
* `{String} package` -`npm` module name, plugin via `npm` module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
后半句不通顺,改为 plugin is imported via npm
module
docs/source/en/basics/plugin.md
Outdated
### Enabling/Disabling plugins | ||
|
||
Built in the upper framework of the plugin, the application does not need to use the package or path configuration, you only need to specify enable or not: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这句话逻辑有点不正确,改为:the application does not need to use the package or path configuration when use the plugin built in the upper framework
docs/source/en/basics/plugin.md
Outdated
|
||
```js | ||
// For the built-in plug-in, you can use the following simple way to turn on or off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plug-in -> plugin
docs/source/en/basics/plugin.md
Outdated
``` | ||
|
||
This way, `npm i --production` in the production environment does not need to download the`egg-dev` package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way -> in the way
docs/source/en/basics/plugin.md
Outdated
### Package name and path | ||
|
||
* The `package` is introduced in the `npm` require style which is the most common way to import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the npm
require style 改为 in the npm
way ,require 感觉冗余
docs/source/en/basics/plugin.md
Outdated
## Plugin list | ||
|
||
* Framework default built-in enterprise applications [Common plug-in](https://eggjs.org/zh-cn/plugins/): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
built-in 是个形容词,在这里应该为动词才对 builds in
Ping @SunShinewyf |
docs/source/en/basics/plugin.md
Outdated
### Enabling/Disabling plugins | ||
|
||
The application does not need the package or path configuration when using the plugins built in the framework. You only need to specify whether they are enabled or not: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the framework -> the upper framework
把这个改了就可以合并了哈~ |
@SunShinewyf done |
docs: translation for basic plugin (#2166)
This PR is intended to provide an translation for
/basics/plugin.md
missing in #363I am not sure about the part